Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rh-mongodb34 #256

Merged
merged 5 commits into from
Oct 8, 2017
Merged

Add rh-mongodb34 #256

merged 5 commits into from
Oct 8, 2017

Conversation

omron93
Copy link
Contributor

@omron93 omron93 commented Aug 28, 2017

Add Mongodb 3.4 from RH Software Collections.

This PR also add latest directory which always contains latest version. In this directory development of images is done and git history is preserved there after adding new image versions. To allow this please DON'T SQUASH this PR using github UI (at least two commits are required), thanks.

@hhorak What to do to make available rh-mongodb34* packages built in CBS?

@pkubatrh
Copy link
Member

It would be better to use 2.4 as the base for latest, since that is the version that will have most of the history (except some of the recent changes)

@omron93 omron93 force-pushed the add-rh-mongodb34 branch 2 times, most recently from af3f59d to 0b995c8 Compare August 28, 2017 11:21
@omron93
Copy link
Contributor Author

omron93 commented Aug 28, 2017

It would be better to use 2.4 as the base for latest, since that is the version that will have most of the history (except some of the recent changes)

On the other hand a lot of changed since 3.2 was added (and changes was aiming to it). And I thing it is more that half of the code was somehow rewritten/restructured.
That is true that 2.4 contains more history, but latest changes in 3.2 after 2.4 deprecation are more useful in future (as mentioned abore the code is rewritten).

@pkubatrh So how to do to have changes from 2.4 and to keep also changes made to 3.2 after 2.4 deprecation?

@pkubatrh
Copy link
Member

So how to do to have changes from 2.4 and to keep also changes made to 3.2 after 2.4 deprecation?

I guess you could apply all of the recent changes that went into 3.2 after 2.4 got deprecated on top of 2.4 as part of the PR but that would get real messy and most likely not worth the hassle...

I have nothing against keeping the current state (latest based on 3.2) if you think the recent history is more valuable.

@hhorak
Copy link
Member

hhorak commented Aug 29, 2017

@omron93 as for the packages in cbs, I expect them to be on bulidlogs (testing repo today or tomorrow)

As for the question whether to use 2.4 or 3.2 as a base, my view is that I think we should try to keep history if possible, but if that would require a lot of work like applying patches one by one, I'd say let's just use 3.2.. the history is handy, but one can always figure out the necessary information by some git dancing..

@omron93
Copy link
Contributor Author

omron93 commented Sep 26, 2017

@pkubatrh @hhorak Thanks for reviews. So keeping 3.2 as a base for latest.

I finally managed to rebase. So anything to do before merging?

@omron93
Copy link
Contributor Author

omron93 commented Sep 27, 2017

[test]

@omron93
Copy link
Contributor Author

omron93 commented Oct 3, 2017

Rebased.

One change: "workaround" for https://jira.mongodb.org/browse/SERVER-28072 has to be used for all versions because of shared tests. (I planned to do this later, but now I have to add changes to older versions to this PR)

@pkubatrh
Copy link
Member

pkubatrh commented Oct 4, 2017

tests seem to be failing due to:

Error: Invalid port number "//172.18.0.2,172.18.0.3/admin?replicaSet=rs0" in connection string "mongodb://172.18.0.2,172.18.0.3/admin?replicaSet=rs0/test" at src/mongo/shell/mongo.js:135

@@ -37,7 +37,7 @@ CMD ["run-mongod"]
RUN yum repolist > /dev/null && \
yum install -y yum-utils && \
yum-config-manager --disable \* &> /dev/null && \
yum-config-manager --enable rhel-server-rhscl-7-rpms && \
yum-config-manager --enable rhel-server-rhscl-beta-7-rpms && \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rhel-server-rhscl-beta-7-rpms -> rhel-server-rhscl-7-beta-rpms

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed.

@@ -13,7 +13,7 @@ LABEL summary="$SUMMARY" \
io.openshift.expose-services="27017:mongodb" \
io.openshift.tags="database,mongodb,rh-mongodb34" \
com.redhat.component="rh-mongodb34-docker" \
name="rhscl/mongodb-34-rhel7" \
name="rhscl-beta/mongodb-34-rhel7" \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are using the regular rhscl/ namespace this time around so no change needed here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed.

@hhorak
Copy link
Member

hhorak commented Oct 8, 2017

Tests pass, so I guess we can merge it.

@hhorak hhorak merged commit 1add842 into sclorg:master Oct 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants