-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rh-mongodb34 #256
Add rh-mongodb34 #256
Conversation
It would be better to use 2.4 as the base for |
af3f59d
to
0b995c8
Compare
It would be better to use 2.4 as the base for latest, since that is the version that will have most of the history (except some of the recent changes) On the other hand a lot of changed since 3.2 was added (and changes was aiming to it). And I thing it is more that half of the code was somehow rewritten/restructured. @pkubatrh So how to do to have changes from 2.4 and to keep also changes made to 3.2 after 2.4 deprecation? |
I guess you could apply all of the recent changes that went into I have nothing against keeping the current state ( |
@omron93 as for the packages in cbs, I expect them to be on bulidlogs (testing repo today or tomorrow) As for the question whether to use 2.4 or 3.2 as a base, my view is that I think we should try to keep history if possible, but if that would require a lot of work like applying patches one by one, I'd say let's just use 3.2.. the history is handy, but one can always figure out the necessary information by some git dancing.. |
0b995c8
to
640feac
Compare
640feac
to
615babe
Compare
[test] |
615babe
to
6115e4c
Compare
Rebased. One change: "workaround" for https://jira.mongodb.org/browse/SERVER-28072 has to be used for all versions because of shared tests. (I planned to do this later, but now I have to add changes to older versions to this PR) |
tests seem to be failing due to:
|
6115e4c
to
2286db7
Compare
- "workaround" for https://jira.mongodb.org/browse/SERVER-28072 and don't use --host
2286db7
to
f5d85ae
Compare
latest/Dockerfile.rhel7
Outdated
@@ -37,7 +37,7 @@ CMD ["run-mongod"] | |||
RUN yum repolist > /dev/null && \ | |||
yum install -y yum-utils && \ | |||
yum-config-manager --disable \* &> /dev/null && \ | |||
yum-config-manager --enable rhel-server-rhscl-7-rpms && \ | |||
yum-config-manager --enable rhel-server-rhscl-beta-7-rpms && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rhel-server-rhscl-beta-7-rpms -> rhel-server-rhscl-7-beta-rpms
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, fixed.
latest/Dockerfile.rhel7
Outdated
@@ -13,7 +13,7 @@ LABEL summary="$SUMMARY" \ | |||
io.openshift.expose-services="27017:mongodb" \ | |||
io.openshift.tags="database,mongodb,rh-mongodb34" \ | |||
com.redhat.component="rh-mongodb34-docker" \ | |||
name="rhscl/mongodb-34-rhel7" \ | |||
name="rhscl-beta/mongodb-34-rhel7" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are using the regular rhscl/
namespace this time around so no change needed here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, fixed.
f5d85ae
to
ad8ed68
Compare
ad8ed68
to
1c7d1d8
Compare
Tests pass, so I guess we can merge it. |
Add Mongodb 3.4 from RH Software Collections.
This PR also add
latest
directory which always contains latest version. In this directory development of images is done and git history is preserved there after adding new image versions. To allow this please DON'T SQUASH this PR using github UI (at least two commits are required), thanks.@hhorak What to do to make available rh-mongodb34* packages built in CBS?