Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added container-quickstarts as an 'examples' submodule. This contains… #263

Closed

Conversation

jbornemann
Copy link

This contains the updated mongodb statefulset quickstart example from the red hat COP repository. It looks like it might have been copied from there originally.

@centos-ci
Copy link
Collaborator

Can one of the admins verify this patch?

2 similar comments
@centos-ci
Copy link
Collaborator

Can one of the admins verify this patch?

@rhscl-bot
Copy link

Can one of the admins verify this patch?

@omron93
Copy link
Contributor

omron93 commented Oct 10, 2017

This PR looks good to me. Linked container-quickstart contains new information IMPOV.

@jbornemann Is it possible to get commit right into this repository?
Also removed README contained some info about scaling replicaset. Mainly about scaling down and absence of removing members from mongodb configuration. So after big scale down replicaset could be unreachable.

@jbornemann
Copy link
Author

Is it possible to get commit right into this repository?

Sorry, not sure what you mean. Do you mean embed the example directly in this repository? Part of the reasoning behind having it be a submodule was to reduce duplication of work. The RH Container COP actively maintains those examples. Let me know if I misunderstand.

Also removed README contained some info about scaling replicaset. Mainly about scaling down and absence of removing members from mongodb configuration. So after big scale down replicaset could be unreachable.

We could certainly add part/all of the document back.

@omron93
Copy link
Contributor

omron93 commented Oct 11, 2017

Sorry, not sure what you mean. Do you mean embed the example directly in this repository? Part of the reasoning behind having it be a submodule was to reduce duplication of work. The RH Container COP actively maintains those examples. Let me know if I misunderstand.

I understand. I thought about whats a process of contributing into that repo. And if it would be possible to be added as collaborator to that repo to be able to participate in maintaing of this example...

We could certainly add part/all of the document back.

Thanks.

@jbornemann
Copy link
Author

I understand. I thought about whats a process of contributing into that repo. And if it would be possible to be added as collaborator to that repo to be able to participate in maintaing of this example...

You could ask. I believe Eric Sauer, and Andrew Block are the owners of that repository. You will probably have to create a fork, and submit PRs from your fork.

@hhorak
Copy link
Member

hhorak commented Oct 16, 2017

Thanks @jbornemann, that is very interesting. I'm thinking whether including such a repo as a submodule is the best way here, since the repository includes much more than just mongodb examples. Wouldn't a link from README.md to the remote directory be better? If we want to use the remote templates for testing, we can always download latest template and run it, it doesn't need to be a submodule..

@jbornemann jbornemann force-pushed the container-quickstart-example branch from a216489 to a83a8c5 Compare October 16, 2017 17:40
@jbornemann
Copy link
Author

Sure, that's fine by me. I've updated

@rhscl-bot
Copy link

Can one of the admins verify this patch?

6 similar comments
@centos-ci
Copy link
Collaborator

Can one of the admins verify this patch?

@rhscl-bot
Copy link

Can one of the admins verify this patch?

@rhscl-bot
Copy link

Can one of the admins verify this patch?

@rhscl-bot
Copy link

Can one of the admins verify this patch?

@rhscl-bot
Copy link

Can one of the admins verify this patch?

@rhscl-automation
Copy link

Can one of the admins verify this patch?

@hhorak
Copy link
Member

hhorak commented Apr 10, 2024

mongodb container is not maintained any more in this org. closing.

@hhorak hhorak closed this Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants