-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added container-quickstarts as an 'examples' submodule. This contains… #263
Conversation
Can one of the admins verify this patch? |
2 similar comments
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
This PR looks good to me. Linked container-quickstart contains new information IMPOV. @jbornemann Is it possible to get commit right into this repository? |
Sorry, not sure what you mean. Do you mean embed the example directly in this repository? Part of the reasoning behind having it be a submodule was to reduce duplication of work. The RH Container COP actively maintains those examples. Let me know if I misunderstand.
We could certainly add part/all of the document back. |
I understand. I thought about whats a process of contributing into that repo. And if it would be possible to be added as collaborator to that repo to be able to participate in maintaing of this example...
Thanks. |
You could ask. I believe Eric Sauer, and Andrew Block are the owners of that repository. You will probably have to create a fork, and submit PRs from your fork. |
Thanks @jbornemann, that is very interesting. I'm thinking whether including such a repo as a submodule is the best way here, since the repository includes much more than just mongodb examples. Wouldn't a link from README.md to the remote directory be better? If we want to use the remote templates for testing, we can always download latest template and run it, it doesn't need to be a submodule.. |
a216489
to
a83a8c5
Compare
Sure, that's fine by me. I've updated |
Can one of the admins verify this patch? |
6 similar comments
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
mongodb container is not maintained any more in this org. closing. |
This contains the updated mongodb statefulset quickstart example from the red hat COP repository. It looks like it might have been copied from there originally.