Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slightly changed S2i extensible from kosciCZ #41

Merged
merged 11 commits into from
Jan 31, 2018

Conversation

hhorak
Copy link
Member

@hhorak hhorak commented Dec 16, 2017

This is an implementation of flexible feature for the container. It is almost identical what @kosciCZ did in #32. It only puts extended files into place suggested during PR #32 review, and then pre-init hook name was changed to start-hook, which was also chosen hook name in sclorg/postgresql-container#208.

@hhorak hhorak mentioned this pull request Dec 16, 2017
@hhorak
Copy link
Member Author

hhorak commented Dec 19, 2017

[test-openshift]

@hhorak hhorak force-pushed the s2i-extensible-kosciCZ branch from ab95291 to 95f874c Compare January 17, 2018 06:51
@hhorak
Copy link
Member Author

hhorak commented Jan 17, 2018

[test-openshift]

@hhorak
Copy link
Member Author

hhorak commented Jan 17, 2018

Most of these changes were already reviewed as part of PR #32.
FYI @uhliarik, can you provide final ack if you're fine with these changes?

@hhorak
Copy link
Member Author

hhorak commented Jan 17, 2018

[test-openshift]

@uhliarik
Copy link
Member

Changes look reasonable, ACK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants