make the container easily configurable #177
Conversation
Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
[test] |
|
I would love to get some feedback here -- what maintainers think about this approach. |
| @@ -61,6 +61,29 @@ or if it was already present, [`postgres`](http://www.postgresql.org/docs/9.2/st | |||
| is executed and will run as PID 1. You can stop the detached container by running | |||
| `docker stop postgresql_database`. | |||
|
|
|||
| Supplying custom configuration file | |||
There was a problem hiding this comment.
What about add notice about "how to supply custom configuration file"? This section is mainly about getting configuration template.
There was a problem hiding this comment.
good point! there's nothing about running postgres while using the custom template config; will add
There was a problem hiding this comment.
@omron93 I added a commit which should address your comment.
will squash before merge Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
|
Since we are now looking into the possibility of introducing the source-to-image functionality for daemon based images it might make sense to not merge the PR right now, as the way the configuration files are used might get changed (e.g. being stored in |
|
What would be the timeline for s2i-based postgresql? |
I'd say weeks, we already know how to do it (follow the ready-to-merge PR for mongodb available at sclorg/mongodb-container#239). |
|
closing this PR as per above |
TODO
For more info, see https://github.com/TomasTomecek/flexible-postgresql-demo