-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add the cloudevents client to the testing suite. #384
Conversation
[test] |
[test] |
The tests fail because of two upstream packages --
|
Yea, the cloudevents module fails because it needs to run the "build" step before it runs the tests since it is written in typescript. related to this question #386 . My plan was to add an extra step in the cloudevents package to fix this |
a new version has been released https://github.com/cloudevents/sdk-javascript/releases/tag/v7.0.0 going to rerun the tests |
The cloudevents sdk is a major part of the faas-js-runtime and is responsible for converting the requests events into CloudEvents.
c15adea
to
13f598c
Compare
[test] |
@hhorak looks like these tests are now fixed |
@zmiklank tests are passing now that the pino tests have been removed. is there anything else we need to do to get this merged? |
This lgtm, thank you for the PR. |
The cloudevents sdk is a major part of the faas-js-runtime and is responsible for converting the requests events into CloudEvents.