Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add set -ex #17

Closed
torsava opened this issue Mar 25, 2015 · 4 comments
Closed

Add set -ex #17

torsava opened this issue Mar 25, 2015 · 4 comments
Labels
bug major

Comments

@torsava
Copy link
Member

torsava commented Mar 25, 2015

Originally reported by: Robert Kuska (Bitbucket: xkuska, GitHub: Unknown)

More info fedora-python/python3#2
@torsava
Copy link
Member Author

torsava commented Mar 25, 2015

Original comment by Robert Kuska (Bitbucket: xkuska, GitHub: Unknown):

Also consider wrapping whole sections inside scl enable.

@irushchyshyn irushchyshyn mentioned this issue Jan 26, 2017
Merged
@irushchyshyn
Copy link
Collaborator

Whole commands are now wrapped in scl enable and are preceded with set -e according to Packaging Guide.

Closing the issue. Please reopen if necessary.

@voxik
Copy link

voxik commented Apr 28, 2017

Sorry, but this does not appear to be fixed:

https://github.com/sclorg/spec2scl/blob/master/spec2scl/settings.py#L18

There is just "set -e" which is not sufficient ...

@irushchyshyn irushchyshyn reopened this May 2, 2017
irushchyshyn added a commit that referenced this issue May 5, 2017
@irushchyshyn
Add missing -x option to set command (#17)
a96bd7e
@irushchyshyn
Copy link
Collaborator

Thanks for pointing this out! Fixed in a96bd7e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug major
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@voxik @irushchyshyn @torsava