Do not set test.fmf.name attribute if null
#117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #117 +/- ##
==========================================
- Coverage 99.37% 99.17% -0.21%
==========================================
Files 6 6
Lines 480 483 +3
Branches 52 53 +1
==========================================
+ Hits 477 479 +2
- Misses 3 4 +1 ☔ View full report in Codecov by Sentry. |
|
@jamacku Please review it. Thanks |
thrix
force-pushed
the
no-tmt-plan-regex
branch
from
f20d35d to
a0cb190
Compare
This is causing an issue for some of the users, if they do not set the
plan regex:
```
Run sclorg/testing-farm-as-github-action@v2
19 Error: [
20 {
21 "code": "too_small",
22 "minimum": 1,
23 "type": "string",
24 "inclusive": true,
25 "exact": false,
26 "message": "String must contain at least 1 character(s)",
27 "path": [
28 "test",
29 "fmf",
30 "name"
31 ]
32 }
33]
```
From:
https://github.com/osbuild/bootc-image-builder/actions/runs/7874729084/job/21520477899?pr=194
Signed-off-by: Miroslav Vadkerti <mvadkert@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is causing an issue for some of the users, if they do not set the plan regex:
From:
https://github.com/osbuild/bootc-image-builder/actions/runs/7874729084/job/21520477899?pr=194