-
Notifications
You must be signed in to change notification settings - Fork 33
removed resource properties from score files #20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CLI code needs to be updated. Otherwise these examples won't work and that would confuse the users.
Please wait for code changes before approving/merging these changes.
Signed-off-by: Eugene Yarshevich <yarshevich@gmail.com>
7c6ce95
to
4e767d9
Compare
Signed-off-by: Eugene Yarshevich <yarshevich@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Would appreciate someone else to review these changes as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One typeo otherwise looks good.
internal/helm/convert_test.go
Outdated
"user.name": {Required: true, Secret: true}, | ||
"password": {Required: true, Secret: true}, | ||
}, | ||
Type: "posgres", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be postgres
missing a t
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
Signed-off-by: Eugene Yarshevich <yarshevich@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Eugene Y. <ghen@users.noreply.github.com>
Description
We are planning to deprecate resource properties in the Score spec: score-spec/spec#61
What does this PR do?
It removes resource properties from the example score.yaml files we store in this repo
Types of changes
Checklist: