Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to set custom HTML #13

Merged
merged 2 commits into from
Sep 28, 2020

Conversation

jamesfowkes
Copy link
Contributor

With reference to issue #12 , a simple implementation of user-settable custom HTML.

Defaults to using the default WebOTA header, but can be overridden by use of the set_custom_html method.

I kept the changes as simple as possible.

@scottchiefbaker
Copy link
Owner

scottchiefbaker commented Sep 28, 2020

This looks good to me. For consistency with the rest of the code can you rework the braces on the if/then on line 155 and the function definition on 226 to be the same brace style as the init_mdns() function.

Once everything is consistent I will gladly land this. Thanks for taking the time.

Someone on #github suggested that I can send a PR to your branch...

I've never done this before, let's see if it works.
@scottchiefbaker
Copy link
Owner

scottchiefbaker commented Sep 28, 2020

Someone on #github suggested that I send you a PR on your branch to suggest the style fixes. I clicked the wrong button, and it committed to your repo instead of starting a pull-request. Sorry, I'm new at remote branch stuff.

See: dfbaf8e

This is now complete, and looks good. I'll merge it!

@scottchiefbaker scottchiefbaker merged commit c98c830 into scottchiefbaker:master Sep 28, 2020
@jamesfowkes
Copy link
Contributor Author

That's cool, I press the wrong buttons/enter the wrong commands all the time! Glad you were happy with it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants