Catch OverflowError #16
Conversation
|
Rebased to master. |
dool
Outdated
| else: | ||
| ret += char['space'] | ||
| except OverflowError: | ||
| pass |
There was a problem hiding this comment.
Instead of just pass it should also add a space to it, otherwise this line breaks the columns.
| pass | |
| ret += char['space'] |
There was a problem hiding this comment.
Yeah, didn't notice the force required after the rebase on master. Updated now.
jkleckner
force-pushed
the
catch-overflowerror
branch
2 times, most recently
from
12da75d to
077c638
Compare
|
Rebased to master |
jkleckner
force-pushed
the
catch-overflowerror
branch
from
077c638 to
e63f59d
Compare
|
Rebased again. Is this patch of any interest? |
|
Apologies... Github was not sending me alerts for issues and pull requests on this repo. I did not see this until just now. Is this still relevant? I'm working through some backlog. |
|
Yes, this is still relevant. |
This is an application of the patch to dstat described here: - https://bugs.launchpad.net/ubuntu/+source/dstat/+bug/1866619/comments/5
Per the review comment, insert a space on overflow error.
jkleckner
force-pushed
the
catch-overflowerror
branch
from
e63f59d to
290aeff
Compare
|
Rebased again. |
|
I use this with the patch and it is necessary for me. |
|
Before I merge this I need a little more information. What overflow is this catching, and how is it triggered? |
|
This bug report details the disk IO overflow pretty well: https://bugs.launchpad.net/ubuntu/+source/dstat/+bug/1866619 |
|
It also crashes sometimes when adding/removing network interfaces (connecting/disconnecting VPN). |
|
Does this address the random "OverflowError: cannot convert float infinity to integer" from #3? |
Probably, yes. |
|
@jkleckner EXCELLENT. That has been one of my personal pet peeves for 12+ months now. |
ISSUE TYPE
DSTAT VERSION
SUMMARY
This is an application of the patch to dstat described here: