Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NODE_NUMBER define #72

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add NODE_NUMBER define #72

wants to merge 1 commit into from

Conversation

ethomas997
Copy link
Contributor

Adds a NODE_NUMBER define so node ID can be entered as 1 to 8 value instead of I2C address.

--ET

@punkkills
Copy link
Collaborator

This seems good to me.

@scottgchin
Copy link
Owner

I get what this is doing, but is it an issue? If implemented, should we also change the timing server display? It shows the node numbering starting at 0.

@ethomas997
Copy link
Contributor Author

Being able to specify it as 1-8 makes the Arduino-flashing process easier.

@ethomas997
Copy link
Contributor Author

Also, just modified the doc to reference the new NODE_NUMBER define.

@ethomas997
Copy link
Contributor Author

Rebased to master-20181112

@ethomas997 ethomas997 mentioned this pull request Dec 14, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ethomas997 @punkkills @scottgchin