Add 'speakObjsQueue' for phonetic calls #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethomas997
force-pushed
the
etAddSpeakQueue
branch
from
5f60c51
to
4e462d2
Compare
Queue for phonetic calls. Also adds commas to phonetic calls for pauses between name / lap / time.
ethomas997
force-pushed
the
etAddSpeakQueue
branch
from
4e462d2
to
e7b0d03
Compare
|
Rebased to master-20181112 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found that when a phonetic call is issued while one is playing, the second one is dropped (not played). This adds a queue for phonetic calls, leveraging the heartbeat thread to play them.
Also adds commas to phonetic calls for pauses between name / lap / time.
--ET