-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bootstrap theme, missing translation #367
Comments
oh and another thing (I don't know if it's just bootstrap or not): The Username field is required. |
oh and when you click on an image in the bootstrap version the image is opened in a new window, and not with the beautiful fancy popover. Could you implement that? |
Oh great, I'll look into that. I thought it was a theme issue. Waiting for the other stuff :) |
@portapipe for your questions:
Thanks |
Great, so quick fix for the first. |
@scoumbourdis @heruprambadi Hi and thanks for your time. |
What browser you using ? Is it up to date ? |
@heruprambadi the very last Safari and it doesn't work just on the main table page. In the edit page it works, in the single item view page a link is shown, in the main table it open the image in a new tab. |
Hello @heruprambadi , You are right. I was looking the edit page. It doesn't work on the grid. Something to consider for the next release. I will have it as a reminder so I can pick that up. I will let you know once this is done. Cheers |
Yeah.. i just know it. It just work on add/edit 😐 |
hem... so? There's something I can help with? |
(another translation is missing, the "Loading" message when reloading data in a table, bootstrap theme) |
Hello @portapipe . No help on that, you just need to wait really :) A quick update so other people will also know:
|
By the way @portapipe great page: https://portapipe.github.io/Login-GroceryCrud/ pretty easy to understand and with good examples 😃 |
@scoumbourdis oh thanks :) I think I'll create a complete per-table permission system with Read/Write/List/OnlyYourID system for user's groups just for GroceryCrud (with a table of checkboxes). I don't know how to do it right now but I'm trying to figure it out :) |
Hey no problem. @portapipe I want (I don't know if at the end I WILL I am too busy these days tbh) to create a video at my channel with theme "So you want to create an open-source project?" in order to help people create their own open-source projects and to see that it is actually just a decision really! I like your page because it is simple and have just enough examples for the user to understand. I wanted to mention your page as a very good example of how easy you can actually create an open-source project with a webpage and you don't have to pay a dollar for that! What do you think? |
@scoumbourdis well why not, It seems a really good project 😄 It's ok for me. |
no problem. Which methods do you like to be public? |
Well, You can create a method to access every class variable for example, or let it public (not protected) and it should be ok. |
I did search the word protected and I have 212 matches :D I can't turn them all to public really. I would prefer to add more public get functions really. It is all about the autocomplete functionality for grocery CRUD. Do you mind to send me a list because really there are too many? |
Is it ok to return those for start? |
and probably those? protected $unset_texteditor = array(); |
I think that some variables are better to be public then methods, like: protected $state_code = null;
|
Oh I forgot to ask if there is a way to customize the "You don't have permissions for this operation" page, maybe with a template page, (here you explain how to make that BUT) if you add something like p.s. A redirect page should work as well too 👌 BTW I think we should chat live sometimes. |
Hello @portapipe and sorry for the delayed answer. It seems that everything that you are saying are making sense. However the time that I have is very little (I even didn't have enough time to write this). So basically, I need to write everything down and see what I can do first as a priority. So with the latest release of grocery CRUD and bootstrap theme, now the Search %ColumnName% is translatable. My next task is to see the fancybox with the image on bootstrap theme. After that I will check all of your requests (e.g. CK editor... e.t.c.) to add a priority. Thanks |
@scoumbourdis don't worry, I've thought that. |
Yes, I had a quick look of the pull request and it is just that it doesn't consider the
see: http://www.grocerycrud.com/documentation/options_functions/where for more that has less totals. I think that a simple change:
Would do the trick though. Do you have time to change it, test it and do a pull request again? Thanks a lot |
@scoumbourdis here you go, done and pulled ;) |
hello i have the same problem with the GC bootstrap theme which the global search is not working... public function add_students()
$post_array['quarter_exam'] = 20; return $post_array; nevermind the rest... of the code i am using $crud->set_relation('year_section','section_list','{yearLevel} {year_section}'); and in this column it is not working.. please help! here are the screenshots. |
Hey @sephinah I think this should be posted as a different issue (it's not a missing translation). I also don't think it's a good idea(tm) or maybe even illegal to post 9th graders' personal information :-P |
Hi.
I've just bought the bootstrap theme.
Awesome and warmly suggested!
BUT. On the top of each column, the search box, it's just "Search %name%" and is not localized.
I've posted that here because I really don't know where to write it.
The text was updated successfully, but these errors were encountered: