Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 7.3 notice: Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? #468

Closed
mlopezcoria opened this issue Dec 20, 2018 · 2 comments

Comments

@mlopezcoria
Copy link

After updating php to version 7.3 I get this warning:

Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /var/www/example.com/public_html/application/libraries/Grocery_CRUD.php on line 2836

Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /var/www/example.com/public_html/application/libraries/Grocery_CRUD.php on line 2842

Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /var/www/example.com/public_html/application/libraries/Grocery_CRUD.php on line 2879

Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /var/www/example.com/public_html/application/libraries/Grocery_CRUD.php on line 2885

Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /var/www/example.com/public_html/application/libraries/Grocery_CRUD.php on line 2937

Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /var/www/example.com/public_html/application/libraries/Grocery_CRUD.php on line 2943
@scoumbourdis
Copy link
Owner

scoumbourdis commented Dec 22, 2018

Hello @mlopezcoria,

First of all thanks for mentioning that :) . I will need to replace the continue with continue 2. I just want to test first if this is working for older PHP versions (e.g. PHP 5.4)

Regards
Johnny

scoumbourdis added a commit that referenced this issue Dec 26, 2018
scoumbourdis added a commit that referenced this issue Dec 26, 2018
scoumbourdis added a commit that referenced this issue Dec 26, 2018
@scoumbourdis
Copy link
Owner

Hello @mlopezcoria

I did the changes required so if you have some time can you please download the latest master version to see if this is now working for you?

Regards
Johnny

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants