Skip to content

Commit

Permalink
test: fix redeclared vars in sequential tests
Browse files Browse the repository at this point in the history
PR-URL: nodejs#4999
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
  • Loading branch information
Trott authored and Michael Scovetta committed Apr 2, 2016
1 parent 5a7a880 commit 7679183
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion test/sequential/test-child-process-execsync.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ var msgBuf = new Buffer(msg + '\n');

cmd = `"${process.execPath}" -e "console.log(\'${msg}\');"`;

var ret = execSync(cmd);
ret = execSync(cmd);

assert.strictEqual(ret.length, msgBuf.length);
assert.deepEqual(ret, msgBuf, 'execSync result buffer should match');
Expand Down
4 changes: 2 additions & 2 deletions test/sequential/test-require-cache-without-stat.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,14 +35,14 @@ var counterBefore = counter;

// Now load the module a bunch of times with equivalent paths.
// stat should not be called.
for (var i = 0; i < 100; i++) {
for (let i = 0; i < 100; i++) {
require(common.fixturesDir + '/a');
require('../fixtures/a.js');
require('./../fixtures/a.js');
}

// Do the same with a built-in module
for (var i = 0; i < 100; i++) {
for (let i = 0; i < 100; i++) {
require('http');
}

Expand Down
4 changes: 2 additions & 2 deletions test/sequential/test-tcp-wrap-listen.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ server.onconnection = function(err, client) {

var req = new WriteWrap();
req.async = false;
var err = client.writeBuffer(req, buffer);
assert.equal(err, 0);
const returnCode = client.writeBuffer(req, buffer);
assert.equal(returnCode, 0);
client.pendingWrites.push(req);

console.log('client.writeQueueSize: ' + client.writeQueueSize);
Expand Down

0 comments on commit 7679183

Please sign in to comment.