Don't hardcode Id for root #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Thank you for jumping in. I was really worried by leaving hardcoded id in the blogpost but found no clean solution for this. Thanks! Thank you! |
scrabsha
approved these changes
Dec 7, 2021
|
@aDotInTheVoid can I add a link to your github/twitter/anything else profile at the end of the post? |
|
A link to my github would be lovely, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Json ID's are opaque, and may be changed at any point (In fact, I;m: To quote the rfc:
In fact, Its possible rustdoc should mangle
Ids, so they dont look human readable, because they arn't indended to convey any information themself.Also: Thanks for writing this post, and I'm super glad to see people finding uses for rustdoc-json. Please file issues if you run into anything or can think of improvements to the json format.