chore(refactor): Move activate_egg function into caller

scrapyd/runner.py

@@ -3,10 +3,28 @@
 import tempfile
 from contextlib import contextmanager
 
+import pkg_resources
 from scrapy.utils.misc import load_object
 
 from scrapyd import Config
-from scrapyd.eggutils import activate_egg
+from scrapyd.exceptions import BadEggError
+
+
+def activate_egg(eggpath):
+    """Activate a Scrapy egg file. This is meant to be used from egg runners
+    to activate a Scrapy egg file. Don't use it from other code as it may
+    leave unwanted side effects.
+    """
+    distributions = pkg_resources.find_distributions(eggpath)
+    if isinstance(distributions, tuple):
+        raise BadEggError
+    try:
+        d = next(distributions)
+    except StopIteration:
+        raise BadEggError from None
+    d.activate()
+    settings_module = d.get_entry_info("scrapy", "settings").module_name
+    os.environ.setdefault("SCRAPY_SETTINGS_MODULE", settings_module)
 
 
 @contextmanager

tests/test_dont_load_settings.py

@@ -8,7 +8,7 @@ class SettingsSafeModulesTest(unittest.TestCase):
         "scrapy.utils.project",
         "scrapy.utils.conf",
         "scrapyd.interfaces",
-        "scrapyd.eggutils",
+        "scrapyd.runner",
     )
 
     def test_modules_that_shouldnt_load_settings(self):