Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rollup-verifier): delete committed batch meta when reverting a batch #1000

Merged
merged 3 commits into from
Aug 26, 2024

Conversation

colinlyguo
Copy link
Member

@colinlyguo colinlyguo commented Aug 24, 2024

1. Purpose or design rationale of this PR

Only for logic completeness sake.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • fix: A bug fix

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change

@Thegaram Thegaram merged commit 03f3b2b into develop Aug 26, 2024
8 checks passed
@Thegaram Thegaram deleted the fix/rollup-verifier-add-delete-committed-batch-meta branch August 26, 2024 09:15
0xmountaintop pushed a commit that referenced this pull request Aug 26, 2024
…tch (#1000)

* fix(rollup-verifier): delete committed batch metadata when reverting a batch

* chore: auto version bump [bot]

* remove a comment

---------

Co-authored-by: colinlyguo <colinlyguo@users.noreply.github.com>
lwedge99 pushed a commit to sentioxyz/scroll-geth that referenced this pull request Aug 27, 2024
…tch (scroll-tech#1000)

* fix(rollup-verifier): delete committed batch metadata when reverting a batch

* chore: auto version bump [bot]

* remove a comment

---------

Co-authored-by: colinlyguo <colinlyguo@users.noreply.github.com>
0xmountaintop pushed a commit that referenced this pull request Aug 30, 2024
…tch (#1000)

---------

Co-authored-by: colinlyguo <colinlyguo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants