Generate L1Blocks system tx #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icemelon
changed the title
Thegaram
reviewed
May 5, 2024
vyzo
reviewed
May 8, 2024
|
I'll merge this PR first to test it out. We can make changes or fixes in the subsequent prs. |
Thegaram
reviewed
May 11, 2024
| @@ -273,6 +273,18 @@ func (st *StateTransition) buyGas() error { | |||
|
|
|||
| func (st *StateTransition) preCheck() error { | |||
| if st.msg.IsSystemTx() { | |||
| // Make sure this transaction's nonce is correct. | |||
There was a problem hiding this comment.
These checks are not needed since the nonce field was removed.
| return s.scope.Track(s.l1BlocksPool.l1BlocksFeed.Subscribe(ch)) | ||
| } | ||
|
|
||
| func (s *SyncService) CollectL1BlocksTxs(latestL1BlockNumberOnL2, maxNumTxs uint64) []*types.SystemTx { |
There was a problem hiding this comment.
Will this method be able to handle L2 reorgs? E.g. when we've marked some L1 blocks as included (removed from pendingL1BlocksTxs) but then some blocks are reorged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Purpose or design rationale of this PR
Generate L1Blocks system tx
2. PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
3. Deployment tag versioning
Has the version in
params/version.gobeen updated?4. Breaking change label
Does this PR have the
breaking-changelabel?