forked from ethereum/go-ethereum
-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: backport flatCallTracer #895
Merged
omerfirmak
merged 3 commits into
scroll-tech:develop
from
draganm:backport-flatcall-tracer
Aug 23, 2024
Merged
feat: backport flatCallTracer #895
omerfirmak
merged 3 commits into
scroll-tech:develop
from
draganm:backport-flatcall-tracer
Aug 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draganm
force-pushed
the
backport-flatcall-tracer
branch
3 times, most recently
from
July 17, 2024 10:57
f6d7e1c
to
65dda8e
Compare
0xmountaintop
previously approved these changes
Jul 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have compared with flat call tracer on upstream
overall looks good, just some nitpicks
omerfirmak
reviewed
Jul 31, 2024
achmand
force-pushed
the
backport-flatcall-tracer
branch
from
August 13, 2024 07:54
e22cfb0
to
b144e8d
Compare
Co-authored-by: HAOYUatHZ <37070449+HAOYUatHZ@users.noreply.github.com>
achmand
force-pushed
the
backport-flatcall-tracer
branch
from
August 13, 2024 08:01
b144e8d
to
371c79e
Compare
@HAOYUatHZ @omerfirmak anything else required to merge this PR? |
0xmountaintop
approved these changes
Aug 23, 2024
omerfirmak
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Purpose or design rationale of this PR
Backport of
flatCallTracer
added in Geth 1.11.32. PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
3. Deployment tag versioning
Has the version in
params/version.go
been updated?4. Breaking change label
Does this PR have the
breaking-change
label?