Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(libzkp):unbounded depth serde json #920

Merged
merged 28 commits into from
Jul 24, 2024
Merged

feat(libzkp):unbounded depth serde json #920

merged 28 commits into from
Jul 24, 2024

Conversation

georgehao
Copy link
Member

1. Purpose or design rationale of this PR

...

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

@georgehao
feat: add transactions len metrics of block processer
d2014b8
@georgehao
Merge branch 'develop' of github.com:scroll-tech/go-ethereum into dev…
36d5590 
…elop
@georgehao
Merge branch 'develop' of github.com:scroll-tech/go-ethereum into dev…
00a75fa 
…elop
@georgehao
Merge branch 'develop' of github.com:scroll-tech/go-ethereum into dev…
77b8381 
…elop
@georgehao
Merge branch 'develop' of github.com:scroll-tech/go-ethereum into dev…
6be368b 
…elop
@georgehao
Merge branch 'develop' of github.com:scroll-tech/go-ethereum into dev…
d4d1e9a 
…elop
@georgehao
Merge branch 'develop' of github.com:scroll-tech/go-ethereum into dev…
c9b8b4a 
…elop
@georgehao
Merge branch 'develop' of github.com:scroll-tech/go-ethereum into dev…
f01e6c3 
…elop
@georgehao
Merge branch 'develop' of github.com:scroll-tech/go-ethereum into dev…
728ee6c 
…elop
@georgehao
Merge branch 'develop' of github.com:scroll-tech/go-ethereum into dev…
5a34f06 
…elop
@georgehao
Merge branch 'develop' of github.com:scroll-tech/go-ethereum into dev…
4e05762 
…elop
@georgehao
Merge branch 'develop' of github.com:scroll-tech/go-ethereum into dev…
3e2bccc 
…elop
@georgehao
Merge branch 'develop' of github.com:scroll-tech/go-ethereum into dev…
e17a131 
…elop
@georgehao
Merge branch 'develop' of github.com:scroll-tech/go-ethereum into dev…
109b703 
…elop
@georgehao
Merge branch 'develop' of github.com:scroll-tech/go-ethereum into dev…
8d0a496 
…elop
@georgehao
Merge branch 'develop' of github.com:scroll-tech/go-ethereum into dev…
a73bbdb 
…elop
@georgehao
Merge branch 'develop' of github.com:scroll-tech/go-ethereum into dev…
6753d83 
…elop
@georgehao
Merge branch 'develop' of github.com:scroll-tech/go-ethereum into dev…
5c6b619 
…elop
@georgehao
Merge branch 'develop' of github.com:scroll-tech/go-ethereum into dev…
d33e5d6 
…elop
@georgehao
Merge branch 'develop' of github.com:scroll-tech/go-ethereum into dev…
a7c195b 
…elop
@georgehao
Merge branch 'develop' of github.com:scroll-tech/go-ethereum into dev…
349b625 
…elop
@georgehao
Merge branch 'develop' of github.com:scroll-tech/go-ethereum into dev…
3046c6f 
…elop
@georgehao
Merge branch 'develop' of github.com:scroll-tech/go-ethereum into dev…
a763626 
…elop
@georgehao
fix
db4c36a
@georgehao
Merge branch 'develop' into feat/unbounded_depth_serde_json
a5d9882
@georgehao
format
cca036d
0xmountaintop
0xmountaintop previously approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@0xmountaintop 0xmountaintop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on a validator node, works good.

  1. it pass block validation
  2. scroll_getBlockByNumber can return row consumptions, which indicates the ApplyBlock (and hence MakeRustTrace) path is good

@0xmountaintop 0xmountaintop merged commit df3713e into develop Jul 24, 2024
8 checks passed
@0xmountaintop 0xmountaintop deleted the feat/unbounded_depth_serde_json branch July 24, 2024 03:59
achmand pushed a commit to draganm/go-ethereum that referenced this pull request Aug 13, 2024
@georgehao @achmand
feat(libzkp):unbounded depth serde json (scroll-tech#920)
40fdee9 
* feat: add transactions len metrics of block processer

* fix

* format

* chore: auto version bump [bot]

* remove unusd code

---------

Co-authored-by: georgehao <georgehao@users.noreply.github.com>
lwedge99 pushed a commit to sentioxyz/scroll-geth that referenced this pull request Aug 27, 2024
@georgehao @lwedge99
feat(libzkp):unbounded depth serde json (scroll-tech#920)
3ab0b05 
* feat: add transactions len metrics of block processer

* fix

* format

* chore: auto version bump [bot]

* remove unusd code

---------

Co-authored-by: georgehao <georgehao@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xmountaintop 0xmountaintop 0xmountaintop approved these changes

@Thegaram Thegaram Awaiting requested review from Thegaram

@omerfirmak omerfirmak Awaiting requested review from omerfirmak

Assignees
No one assigned
Labels
bump-version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@georgehao @0xmountaintop