Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rollup-verifier): codecv4 #991

Merged
merged 20 commits into from
Aug 23, 2024
Merged

Conversation

colinlyguo
Copy link
Member

@colinlyguo colinlyguo commented Aug 19, 2024

1. Purpose or design rationale of this PR

  1. store version and versionedHash in the database.
  2. glue code for backward compatibility, can be removed after upgrade.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • feat: A new feature

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change

@colinlyguo colinlyguo changed the base branch from develop to add-darwinv2 August 21, 2024 07:41
Base automatically changed from add-darwinv2 to develop August 21, 2024 16:36
Copy link

@Thegaram Thegaram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

go.mod Outdated Show resolved Hide resolved
rollup/rollup_sync_service/rollup_sync_service.go Outdated Show resolved Hide resolved
Thegaram
Thegaram previously approved these changes Aug 22, 2024
zimpha
zimpha previously approved these changes Aug 22, 2024
@colinlyguo colinlyguo dismissed stale reviews from zimpha and Thegaram via 2982636 August 22, 2024 22:41
@colinlyguo colinlyguo merged commit 9de4980 into develop Aug 23, 2024
9 checks passed
@colinlyguo colinlyguo deleted the feat/rollup-verifier-codecv4 branch August 23, 2024 06:50
0xmountaintop pushed a commit that referenced this pull request Aug 26, 2024
* feat(rollup-verifier): codecv4

* fix golint

* enhancements

* rename

* rename

* feat: add darwinv2 in genesis config

* bump version

* fix typo

* Update params/config.go

Co-authored-by: georgehao <haohongfan@gmail.com>

* add DarwinV2

* address comments

* move a comment to other places

* small refactors

* chore: auto version bump [bot]

* update da-codec commit

* fix a bug

---------

Co-authored-by: georgehao <haohongfan@gmail.com>
Co-authored-by: Péter Garamvölgyi <peter@scroll.io>
Co-authored-by: colinlyguo <colinlyguo@users.noreply.github.com>
lwedge99 pushed a commit to sentioxyz/scroll-geth that referenced this pull request Aug 27, 2024
* feat(rollup-verifier): codecv4

* fix golint

* enhancements

* rename

* rename

* feat: add darwinv2 in genesis config

* bump version

* fix typo

* Update params/config.go

Co-authored-by: georgehao <haohongfan@gmail.com>

* add DarwinV2

* address comments

* move a comment to other places

* small refactors

* chore: auto version bump [bot]

* update da-codec commit

* fix a bug

---------

Co-authored-by: georgehao <haohongfan@gmail.com>
Co-authored-by: Péter Garamvölgyi <peter@scroll.io>
Co-authored-by: colinlyguo <colinlyguo@users.noreply.github.com>
0xmountaintop pushed a commit that referenced this pull request Aug 30, 2024
Co-authored-by: georgehao <haohongfan@gmail.com>

---------

Co-authored-by: georgehao <haohongfan@gmail.com>
Co-authored-by: Péter Garamvölgyi <peter@scroll.io>
Co-authored-by: colinlyguo <colinlyguo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants