forked from ethereum/go-ethereum
-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rollup-verifier): codecv4 #991
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: georgehao <haohongfan@gmail.com>
Thegaram
reviewed
Aug 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thegaram
previously approved these changes
Aug 22, 2024
zimpha
previously approved these changes
Aug 22, 2024
zimpha
approved these changes
Aug 23, 2024
0xmountaintop
approved these changes
Aug 23, 2024
0xmountaintop
pushed a commit
that referenced
this pull request
Aug 26, 2024
* feat(rollup-verifier): codecv4 * fix golint * enhancements * rename * rename * feat: add darwinv2 in genesis config * bump version * fix typo * Update params/config.go Co-authored-by: georgehao <haohongfan@gmail.com> * add DarwinV2 * address comments * move a comment to other places * small refactors * chore: auto version bump [bot] * update da-codec commit * fix a bug --------- Co-authored-by: georgehao <haohongfan@gmail.com> Co-authored-by: Péter Garamvölgyi <peter@scroll.io> Co-authored-by: colinlyguo <colinlyguo@users.noreply.github.com>
lwedge99
pushed a commit
to sentioxyz/scroll-geth
that referenced
this pull request
Aug 27, 2024
* feat(rollup-verifier): codecv4 * fix golint * enhancements * rename * rename * feat: add darwinv2 in genesis config * bump version * fix typo * Update params/config.go Co-authored-by: georgehao <haohongfan@gmail.com> * add DarwinV2 * address comments * move a comment to other places * small refactors * chore: auto version bump [bot] * update da-codec commit * fix a bug --------- Co-authored-by: georgehao <haohongfan@gmail.com> Co-authored-by: Péter Garamvölgyi <peter@scroll.io> Co-authored-by: colinlyguo <colinlyguo@users.noreply.github.com>
0xmountaintop
pushed a commit
that referenced
this pull request
Aug 30, 2024
Co-authored-by: georgehao <haohongfan@gmail.com> --------- Co-authored-by: georgehao <haohongfan@gmail.com> Co-authored-by: Péter Garamvölgyi <peter@scroll.io> Co-authored-by: colinlyguo <colinlyguo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Purpose or design rationale of this PR
version
andversionedHash
in the database.2. PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
3. Deployment tag versioning
Has the version in
params/version.go
been updated?4. Breaking change label
Does this PR have the
breaking-change
label?