chore: turn on associated type defaults (#87) #376
Annotations
19 warnings
accessing first element with `slice.get(0)`:
halo2_proofs/src/helpers.rs#L228
warning: accessing first element with `slice.get(0)`
--> halo2_proofs/src/helpers.rs:228:40
|
228 | 4 + slice.len() * (4 + field_len * slice.get(0).map(|poly| poly.len()).unwrap_or(0))
| ^^^^^^^^^^^^ help: try: `slice.first()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
= note: `-W clippy::get-first` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::get_first)]`
|
items after a test module:
halo2_proofs/src/helpers.rs#L93
warning: items after a test module
--> halo2_proofs/src/helpers.rs:93:1
|
93 | mod test {
| ^^^^^^^^
...
116 | pub trait SerdeCurveAffine: CurveAffine + SerdeObject {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
...
140 | impl<C: CurveAffine + SerdeObject> SerdeCurveAffine for C {}
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
141 |
142 | pub trait SerdePrimeField: PrimeField + SerdeObject {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
...
175 | impl<F: PrimeField + SerdeObject> SerdePrimeField for F {}
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
...
181 | pub fn pack(bits: &[bool]) -> u8 {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
...
192 | pub fn unpack(byte: u8, bits: &mut [bool]) {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
...
199 | / pub(crate) fn read_polynomial_vec<R: io::Read, F: SerdePrimeField, B>(
200 | | reader: &mut R,
201 | | format: SerdeFormat,
202 | | ) -> io::Result<Vec<Polynomial<F, B>>> {
| |______________________________________^
...
213 | / pub(crate) fn write_polynomial_slice<W: io::Write, F: SerdePrimeField, B>(
214 | | slice: &[Polynomial<F, B>],
215 | | writer: &mut W,
216 | | format: SerdeFormat,
217 | | ) -> io::Result<()> {
| |___________________^
...
226 | pub(crate) fn polynomial_slice_byte_length<F: PrimeField, B>(slice: &[Polynomial<F, B>]) -> usize {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#items_after_test_module
= note: `-W clippy::items-after-test-module` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::items_after_test_module)]`
= help: move the items to before the test module was defined
|
you seem to use `.enumerate()` and immediately discard the index:
halo2_proofs/src/dev.rs#L636
warning: you seem to use `.enumerate()` and immediately discard the index
--> halo2_proofs/src/dev.rs:636:32
|
636 | for (_i, sub_range) in ranges.iter().enumerate() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index
= note: `-W clippy::unused-enumerate-index` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::unused_enumerate_index)]`
help: remove the `.enumerate()` call
|
636 | for sub_range in ranges.iter() {
| ~~~~~~~~~ ~~~~~~~~~~~~~
|
accessing first element with `slice.get(0)`:
halo2_proofs/src/helpers.rs#L228
warning: accessing first element with `slice.get(0)`
--> halo2_proofs/src/helpers.rs:228:40
|
228 | 4 + slice.len() * (4 + field_len * slice.get(0).map(|poly| poly.len()).unwrap_or(0))
| ^^^^^^^^^^^^ help: try: `slice.first()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
= note: `-W clippy::get-first` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::get_first)]`
|
you seem to use `.enumerate()` and immediately discard the index:
halo2_proofs/src/dev.rs#L636
warning: you seem to use `.enumerate()` and immediately discard the index
--> halo2_proofs/src/dev.rs:636:32
|
636 | for (_i, sub_range) in ranges.iter().enumerate() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index
= note: `-W clippy::unused-enumerate-index` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::unused_enumerate_index)]`
help: remove the `.enumerate()` call
|
636 | for sub_range in ranges.iter() {
| ~~~~~~~~~ ~~~~~~~~~~~~~
|
unused doc comment:
halo2_proofs/src/dev/cost.rs#L110
warning: unused doc comment
--> halo2_proofs/src/dev/cost.rs:110:13
|
110 | /// Selector assignments used for optimization pass
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
111 | selectors: vec![vec![false; n]; num_selectors],
| ---------------------------------------------- rustdoc does not generate documentation for expression fields
|
= help: use `//` for a plain comment
|
unused doc comment:
halo2_proofs/src/dev/cost.rs#L108
warning: unused doc comment
--> halo2_proofs/src/dev/cost.rs:108:13
|
108 | /// Pairs of cells between which we have equality constraints.
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
109 | equality: vec![],
| ---------------- rustdoc does not generate documentation for expression fields
|
= help: use `//` for a plain comment
|
unused doc comment:
halo2_proofs/src/dev/cost.rs#L106
warning: unused doc comment
--> halo2_proofs/src/dev/cost.rs:106:13
|
106 | /// Any cells assigned outside of a region.
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
107 | loose_cells: vec![],
| ------------------- rustdoc does not generate documentation for expression fields
|
= help: use `//` for a plain comment
= note: `#[warn(unused_doc_comments)]` on by default
|
unused imports: `Scope`, `join`:
halo2_proofs/src/multicore.rs#L12
warning: unused imports: `Scope`, `join`
--> halo2_proofs/src/multicore.rs:12:5
|
12 | join, scope, Scope,
| ^^^^ ^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
unused doc comment:
halo2_proofs/src/dev/cost.rs#L110
warning: unused doc comment
--> halo2_proofs/src/dev/cost.rs:110:13
|
110 | /// Selector assignments used for optimization pass
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
111 | selectors: vec![vec![false; n]; num_selectors],
| ---------------------------------------------- rustdoc does not generate documentation for expression fields
|
= help: use `//` for a plain comment
|
unused doc comment:
halo2_proofs/src/dev/cost.rs#L108
warning: unused doc comment
--> halo2_proofs/src/dev/cost.rs:108:13
|
108 | /// Pairs of cells between which we have equality constraints.
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
109 | equality: vec![],
| ---------------- rustdoc does not generate documentation for expression fields
|
= help: use `//` for a plain comment
|
unused doc comment:
halo2_proofs/src/dev/cost.rs#L106
warning: unused doc comment
--> halo2_proofs/src/dev/cost.rs:106:13
|
106 | /// Any cells assigned outside of a region.
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
107 | loose_cells: vec![],
| ------------------- rustdoc does not generate documentation for expression fields
|
= help: use `//` for a plain comment
= note: `#[warn(unused_doc_comments)]` on by default
|
unused imports: `Scope`, `join`:
halo2_proofs/src/multicore.rs#L12
warning: unused imports: `Scope`, `join`
--> halo2_proofs/src/multicore.rs:12:5
|
12 | join, scope, Scope,
| ^^^^ ^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
Clippy (beta)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Clippy (beta)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|