Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Incorrect Variable Name #358

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

intls
Copy link

@intls intls commented Oct 8, 2024

IMPORTANT: Please do not create a Pull Request without creating an issue first.Any change needs to be discussed before proceeding.

Closing issues

closes #357

...

Description

The incorrect variable name caused the scrollTo function to fail, disrupting the scrolling functionality of the .sidebar-nav-inner element. By correcting the variable name to scrollElement, it will restore proper scrolling behavior, enhancing user navigation and experience.
...

Changes

Changed scollElement to scrollElement

  • High level
  • changes that
  • you made

Copy link

netlify bot commented Oct 8, 2024

Deploy Preview for scroll-documentation ready!

Name Link
🔨 Latest commit 54a33c8
🔍 Latest deploy log https://app.netlify.com/sites/scroll-documentation/deploys/6705aa2d6100ef00089c15ff
😎 Deploy Preview https://deploy-preview-358.docs.scroll.xyz
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@intls intls changed the title Corrected errors fix: Incorrect Variable Name Oct 8, 2024
@intls intls changed the title fix: Incorrect Variable Name ixed Incorrect Variable Name Oct 8, 2024
@intls intls changed the title ixed Incorrect Variable Name Fixed Incorrect Variable Name Oct 8, 2024
@intls
Copy link
Author

intls commented Oct 11, 2024

Good to go! @dghelm @emilyJLin95 @isabellewei

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Incorrect Variable Name
1 participant