Skip to content

Commit

Permalink
address comments
Browse files Browse the repository at this point in the history
  • Loading branch information
NazariiDenha committed Sep 27, 2024
1 parent 7b6d97d commit 0411976
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
1 change: 0 additions & 1 deletion rollup/internal/controller/sender/sender.go
Original file line number Diff line number Diff line change
Expand Up @@ -467,7 +467,6 @@ func (s *Sender) resubmitTransaction(tx *gethTypes.Transaction, baseFee, blobBas
log.Info("Transaction gas adjustment details", "service", s.service, "name", s.name, "txInfo", txInfo)

nonce := tx.Nonce()
tx.Hash()
s.metrics.resubmitTransactionTotal.WithLabelValues(s.service, s.name).Inc()
tx, err := s.createAndSendTx(&feeData, tx.To(), tx.Data(), tx.BlobTxSidecar(), &nonce)
if err != nil {
Expand Down
6 changes: 3 additions & 3 deletions rollup/internal/controller/sender/transaction_signer.go
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,9 @@ func NewTransactionSigner(config *config.SignerConfig, chainID *big.Int) (*Trans
addr: crypto.PubkeyToAddress(privKey.PublicKey),
}, nil
case RemoteSignerSignerType:
if config.SignerAddress == "" {
return nil, fmt.Errorf("failed to create RemoteSigner, signer address is empty")
}
rpcClient, err := rpc.Dial(config.RemoteSignerUrl)
if err != nil {
return nil, fmt.Errorf("failed to dial rpc client, err: %w", err)
Expand Down Expand Up @@ -97,9 +100,6 @@ func (ts *TransactionSigner) SignTransaction(ctx context.Context, tx *gethTypes.
}

func (ts *TransactionSigner) SetNonce(nonce uint64) {
if ts.config.SignerType == PrivateKeySignerType {
ts.auth.Nonce = big.NewInt(int64(nonce))
}
ts.nonce = nonce
}

Expand Down

0 comments on commit 0411976

Please sign in to comment.