* Refactored v1/v010 contracts to be in the same path #1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Cashmaney
commented
Sep 5, 2022
Cashmaney
commented
- Refactored test contract path - fuck having random contracts in the go module rather than with the other contracts, and refactored most of the hard coded paths so it's easier to move around. Still need to do some work here, but for now I mostly want to see that test pass and shit
- Deleted schema package (the one in our cw1.0 repo is the same, no need to keep this here)
* Refactored test contract path - fuck having random contracts in the go module rather than with the other contracts, and refactored most of the hard coded paths so it's easier to move around. Still need to do some work here, but for now I mostly want to see that test pass and shit * Deleted schema package (the one in our cw1.0 repo is the same, no need to keep this here)
Cashmaney
requested review from
reuvenpo,
toml01,
assafmo and
liorbond
as code owners
Deploying with
|
| Latest commit: |
1d3582f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f3e9ebf3.swagger-preview.pages.dev |
| Branch Preview URL: | https://refactored-test-contracts.swagger-preview.pages.dev |
…t-contracts # Conflicts: # x/compute/internal/keeper/test_common.go
Moved all the paths to be defined in test_common.go
assafmo
approved these changes
Sep 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.