-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add usrsctp_get_timeout() #591
base: master
Are you sure you want to change the base?
Conversation
Oops, should obviously be finding the minimum delta, not the maximum. Need more coffee! 😅 Fixing. |
To improve energy efficiency when integrating with an event loop.
bd18f42
to
5fb4b83
Compare
Fixed. |
@tuexen any chance for this PR to be reviewed? It makes lot of sense. |
Wow, I didn't see this before. This looks like an epic performance and energy improvement! |
Even a better approach, when integrating with an even loop, would be being able to assign an event file descriptor ( This way there would be an alternative to timers, and the app would be notified by the event loop only when there is something to be done. EDIT; Perhaps that is something that can be achieved with |
Same as PR sctplab#591 by @oleavr in upstream project which has been ignored for 4 years. A little change: Instead of using `int` to hold a `uint32_t` (or -1) let's use a `int64_t`.
Would it be possible to merge this pull request, @tuexen ? It appears to be quite beneficial. |
To improve energy efficiency when integrating with an event loop.
This could also be used internally for the timer thread, to improve on the current behavior where this thread wakes up every 10 ms.