Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(scully-plugin-puppeteer): correctly track requests in bare project #1610

Merged
merged 1 commit into from
Sep 21, 2022
Merged

fix(scully-plugin-puppeteer): correctly track requests in bare project #1610

merged 1 commit into from
Sep 21, 2022

Commits on Sep 21, 2022

  1. fix(scully-plugin-puppeteer): correctly track requests in bare project 

    Previously, instead of adding/removing each request from the `requests`
set, the set itself was added/removed. Since `Set` deduplicates its
values, it would always contain just one item (regardless of how many
requests would be pending) and it would be emptied once the first
request was completed.

This commit fixes this by adding/removing the actual request to/from the
`requests` set.
    @gkalpak
    gkalpak authored Sep 21, 2022
    Configuration menu
    Copy the full SHA
    d71b10e View commit details
    Browse the repository at this point in the history