Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes scverse/muon#111 #112

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Fixes scverse/muon#111 #112

merged 1 commit into from
Sep 11, 2023

Conversation

russellgould
Copy link
Contributor

@russellgould russellgould commented Jun 20, 2023 •
edited
Loading

Fixes #111

@bio-la
Copy link

bio-la commented Aug 23, 2023

Hi all, any update on merging this fix into main?
I have the same error DendrouLab/panpipes#62

thank you!

@deevdevil88 deevdevil88 mentioned this pull request Aug 23, 2023
Closed
@gtca gtca merged commit 61942d6 into scverse:master Sep 11, 2023
@gtca
Copy link
Collaborator

gtca commented Sep 12, 2023 •
edited
Loading

Thanks for the fix, @russellgould! There are also some upcoming changes in mudata itself that should help to avoid unnecessary use of nullable boolean arrays when there are no null values after merging bool metadata columns.

@bio-la
Copy link

bio-la commented Nov 22, 2023

Hey @gtca thanks for merging!
installing muon from pypi pip install muon still fetches a version of the code without this fix, is it possible to push this version?
thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Numpy IndexError in muon._core.tools.mofa
3 participants
@russellgould @bio-la @gtca