Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added options to run mofa in SVI mode #47

Merged
merged 2 commits into from
Feb 8, 2022
Merged

Added options to run mofa in SVI mode #47

merged 2 commits into from
Feb 8, 2022

Conversation

sagar87
Copy link
Contributor

@sagar87 sagar87 commented Jan 21, 2022

Added some arguments that enable to run MOFA using SVI. Made my life a bit easier, though I didn't test it thoroughly. Thanks for the great package.

@gtca gtca merged commit d6f05f9 into scverse:master Feb 8, 2022
@gtca
Copy link
Collaborator

gtca commented Feb 8, 2022

Hey @sagar87, thanks for this PR!
As the interface for MOFA has grown quite extensive already, I added svi_ prefix to the new arguments to semantically group them. I have also changed the defaults to the ones used in the canonical MOFA implementation in R.

Hope that makes sense. Feel free to open new issues or PRs if you think there's anything else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sagar87 @gtca