Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to session-info2 #3384

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Switch to session-info2 #3384

wants to merge 5 commits into from

Conversation

flying-sheep
Copy link
Member

  • Release notes not necessary because:

TODO: update notebooks

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.58%. Comparing base (391d87a) to head (dd916b8).

Files with missing lines Patch % Lines
src/scanpy/logging.py 87.50% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3384   +/-   ##
=======================================
  Coverage   76.58%   76.58%           
=======================================
  Files         111      111           
  Lines       12872    12866    -6     
=======================================
- Hits         9858     9854    -4     
+ Misses       3014     3012    -2     
Files with missing lines Coverage Δ
src/scanpy/logging.py 97.39% <87.50%> (+1.52%) ⬆️

@flying-sheep flying-sheep added this to the 1.11.0 milestone Dec 12, 2024
@flying-sheep flying-sheep marked this pull request as ready for review December 12, 2024 15:57
@flying-sheep flying-sheep requested a review from Intron7 December 12, 2024 16:08
@Intron7
Copy link
Member

Intron7 commented Dec 16, 2024

I like it a lot. However we might need a fallback mode if ipywidgets are not installed.

@flying-sheep
Copy link
Member Author

Great point! It doesn’t fail if the import isn’t possible, but the current fallback is just printing the stack trace. That could be nicer. Adding this in flying-sheep/session-info2#81

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Depend on session-info2
2 participants