ci: enable NullStringApiArgsTest suite #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As a small optimization, to safe a round-trip for a request that we know will fail anyway, we could return an early "server error" (syntax error) without sending the acutal request. |
muzarski
force-pushed
the
null-api-strings-it
branch
from
5e262de to
0d71715
Compare
Lorak-mmk
reviewed
Oct 16, 2024
I explained the reasoning in the code: // Apparently nullptr denotes an empty statement string. // It seems to be intended (for some weird reason, why not save a round-trip???) // to receive a server error in such case (CASS_ERROR_SERVER_SYNTAX_ERROR). // There is a test for this: `NullStringApiArgsTest.Integration_Cassandra_PrepareNullQuery`.
muzarski
force-pushed
the
null-api-strings-it
branch
from
0d71715 to
ff12066
Compare
wprzytula
approved these changes
Oct 16, 2024
Lorak-mmk
approved these changes
Oct 16, 2024
I think we could have different (better) behavior if we are sure that it will not break apps that try to migrate to our driver. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes
cass_session_preparelogic consistent with cpp-driver (even though, I am not a fan of it) and enablesNullStringApiArgsTesttest suite.Pre-review checklist
[ ] I have implemented Rust unit tests for the features/changes introduced..github/workflows/build.ymlingtest_filter..github/workflows/cassandra.ymlingtest_filter.