Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setup step in Build and Cassandra workflows #90

Merged
merged 1 commit into from
Dec 8, 2022

Conversation

Gor027
Copy link
Contributor

@Gor027 Gor027 commented Dec 7, 2022

The workflows fail for current pull requests:

Err:6 http://security.ubuntu.com/ubuntu xenial-security InRelease
The following signatures couldn't be verified because the public key is not available: NO_PUBKEY 40976EAF437D05B5 NO_PUBKEY 3B4FE6ACC0B21F32
Reading package lists...
W: GPG error: http://security.ubuntu.com/ubuntu xenial-security InRelease: The following signatures couldn't be verified because the public key is not available: NO_PUBKEY 40976EAF437D05B5 NO_PUBKEY 3B4FE6ACC0B21F32
E: The repository 'http://security.ubuntu.com/ubuntu xenial-security InRelease' is not signed.

It seems that xenial-security does not maintain keys for the Ubuntu keyserver.
This PR will manually add the keys to the system.

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have enabled appropriate tests in .github/workflows/build.yml in gtest_filter.
  • I have enabled appropriate tests in .github/workflows/cassandra.yml in gtest_filter.

@Gor027 Gor027 requested a review from Lorak-mmk December 8, 2022 14:12
@Gor027
Copy link
Contributor Author

Gor027 commented Dec 8, 2022

@Lorak-mmk currently #78 is blocked by this PR.

@mykaul
Copy link

mykaul commented Dec 8, 2022

Why aren't we using Ubuntu latest in our github actions? (actually, looks like we do, so I'm unsure why are we getting xenial stuff? Some backward compat?)

@avelanarius
Copy link

@mykaul We are using xenial repo for libssl1.0.0 (but off top of my head I don't remember if it's for Rust's TLS or some "legacy" C++ Driver testing code - tests copied from original C++ Driver).

@Gor027
Copy link
Contributor Author

Gor027 commented Dec 8, 2022

Why aren't we using Ubuntu latest in our github actions? (actually, looks like we do, so I'm unsure why are we getting xenial stuff? Some backward compat?)

The tests require libssl1.0.0 which was dropped from the default Ubuntu repos after Ubuntu 18.04, that is why xenial-security was added. Maybe libssl1.1 can be installed instead, which will allow to remove xenial-security from the setup step.

@Gor027
Copy link
Contributor Author

Gor027 commented Dec 8, 2022

I can confirm that the tests successfully pass with libssl1.1, so we can get rid of xenial-security.

The workflows fail for current pull requests as it seems that
xenial-security does not maintain keys for the Ubuntu keyserver.
This will manually add the keys to the system.
@Lorak-mmk Lorak-mmk merged commit 70f6545 into scylladb:master Dec 8, 2022
@mykaul
Copy link

mykaul commented Dec 8, 2022

I can confirm that the tests successfully pass with libssl1.1, so we can get rid of xenial-security.

Good - thanks. 1.0 is not maintained even anymore (I think? https://www.openssl.org/policies/releasestrat.html )
I guess at some point we'll need to move to OpenSSL 3 (is that libssl3 in Ubuntu?), but I assume there's somewhere in the Rust code some work needed to support it?

@piodul
Copy link
Collaborator

piodul commented Dec 9, 2022

I guess at some point we'll need to move to OpenSSL 3 (is that libssl3 in Ubuntu?), but I assume there's somewhere in the Rust code some work needed to support it?

The Rust driver should support it out of the box. Documentation of the crate that we use to bind to OpenSSL states that "OpenSSL versions 1.0.1 through 3.x.x and LibreSSL versions 2.5 through 3.4.1 are supported."

https://docs.rs/openssl/latest/openssl/ , first paragraph

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants