Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unmarshall errors, add condition for nil reference #301

Merged
merged 5 commits into from
Oct 11, 2024
Merged

Fix unmarshall errors, add condition for nil reference #301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9ca8c00
add error on `nil reference` values `smallint`
illia-li Oct 9, 2024
b3eda14
add error on `nil reference` values `int`
illia-li Oct 9, 2024
980a82c
add error on `nil reference` values `bigint`
illia-li Oct 9, 2024
4b2cf7c
add error on `nil reference` values `counter`
illia-li Oct 9, 2024
aaea3eb
fix errors `tinyint`
illia-li Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions serialization/bigint/marshal_utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ func EncString(v string) ([]byte, error) {

n, err := strconv.ParseInt(v, 10, 64)
if err != nil {
return nil, fmt.Errorf("failed to marshal bigint: can not marshal %#v %s", v, err)
return nil, fmt.Errorf("failed to marshal bigint: can not marshal (%T)(%[1]v) %s", v, err)
}
return encInt64(n), nil
}
Expand All @@ -181,11 +181,11 @@ func EncReflect(v reflect.Value) ([]byte, error) {
}
n, err := strconv.ParseInt(val, 10, 64)
if err != nil {
return nil, fmt.Errorf("failed to marshal bigint: can not marshal %#v %s", v.Interface(), err)
return nil, fmt.Errorf("failed to marshal bigint: can not marshal (%T)(%[1]v) %s", v.Interface(), err)
}
return encInt64(n), nil
default:
return nil, fmt.Errorf("failed to marshal bigint: unsupported value type (%T)(%#[1]v)", v.Interface())
return nil, fmt.Errorf("failed to marshal bigint: unsupported value type (%T)(%[1]v)", v.Interface())
}
}

Expand Down
2 changes: 1 addition & 1 deletion serialization/bigint/unmarshal.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ func Unmarshal(data []byte, value interface{}) error {
rv := reflect.ValueOf(value)
rt := rv.Type()
if rt.Kind() != reflect.Ptr {
return fmt.Errorf("failed to unmarshal bigint: unsupported value type (%T)(%#[1]v)", value)
return fmt.Errorf("failed to unmarshal bigint: unsupported value type (%T)(%[1]v)", value)
}
if rt.Elem().Kind() != reflect.Ptr {
return DecReflect(data, rv)
Expand Down
Loading
Loading