Fix float marshal, unmarshall functions
#313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illia-li
force-pushed
the
il/fix/marshal/float
branch
2 times, most recently
from
8ce5e89
to
62153cd
Compare
sylwiaszunejko
requested changes
Oct 17, 2024
marshal.go
Outdated
| @@ -9,6 +9,7 @@ import ( | |||
| "encoding/binary" | |||
| "errors" | |||
| "fmt" | |||
| "github.com/gocql/gocql/serialization/float" | |||
There was a problem hiding this comment.
it should be below with other gocql/serialization imports
serialization/float/marshal.go
Outdated
| switch v := value.(type) { | ||
| case nil: | ||
| return nil, nil | ||
|
|
There was a problem hiding this comment.
is this new line needed?
serialization/float/unmarshal.go
Outdated
| switch v := value.(type) { | ||
| case nil: | ||
| return nil | ||
|
|
There was a problem hiding this comment.
unnecessary new line
dkropachev
requested changes
Oct 17, 2024
illia-li
force-pushed
the
il/fix/marshal/float
branch
from
62153cd
to
1f85aa2
Compare
sylwiaszunejko
approved these changes
Oct 17, 2024
dkropachev
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
no errorbefore, now return an error.