Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if replication went correctly after each query #62

Merged
merged 1 commit into from
Apr 20, 2022
Merged

Check if replication went correctly after each query #62

merged 1 commit into from
Apr 20, 2022

Conversation

Ponewor
Copy link
Contributor

@Ponewor Ponewor commented Apr 14, 2022

Closes #60

piodul
piodul requested changes Apr 19, 2022
View reviewed changes
Copy link
Collaborator

@piodul piodul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, apart from a minor comment.

scylla-cdc-replicator/src/replication_tests.rs Outdated Show resolved Hide resolved
scylla-cdc-replicator/src/replication_tests.rs Outdated Show resolved Hide resolved
@Ponewor Ponewor requested a review from piodul April 19, 2022 14:19
@piodul piodul merged commit fd40068 into scylladb:main Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piodul piodul piodul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modify replication tests so that they check the table state after every query
2 participants
@Ponewor @piodul