Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update alternator dashoard #2226

Merged
merged 4 commits into from
Mar 20, 2024
Merged

Update alternator dashoard #2226

merged 4 commits into from
Mar 20, 2024

Conversation

amnonh
Copy link
Collaborator

@amnonh amnonh commented Mar 19, 2024 •
edited
Loading

This series addresses multiple issues with the alternator dashboard.

  1. It adds a command line option to start the monitoring stack with the alternator dashboard as the default.
  2. It updates the alternator dashboard with newer functionality from the overview dashboard.
  3. A per-DC section now holds extended node tables that combine the relevant information

image

@mykaul
Copy link
Contributor

mykaul commented Mar 19, 2024

It's a bit strange to see the P95 graph under the P99 numbers, but I'm not sure I have a better idea for re-organizing the panels. @tzach , @nyh ?

CC @gmizrahi for awareness - we'll probably want to add support for this with the release of Scylla cloud that will add support for Monitoring 4.7

@mykaul mykaul added the area/alternator Alternator related Issues label Mar 19, 2024
@amnonh
Copy link
Collaborator Author

amnonh commented Mar 19, 2024

@nyh I'll probably be going to make changes on top of this PR, but your feedback will be appreciated

@tzach
Copy link
Contributor

tzach commented Mar 20, 2024

It's a bit strange to see the P95 graph under the P99 numbers, but I'm not sure I have a better idea for re-organizing the panels. @tzach , @nyh ?

It's not under; it's side by side, but I agree it's hard to see.
The section (row with a header) should be clearer.

@mykaul
Copy link
Contributor

mykaul commented Mar 20, 2024

That's one below the other:
image

@amnonh
types.json: add the alternator small stat row and dc nodes table
c7ae1f4
@amnonh
Update the alternator dashboard
397b464 
This patch makes the alterntor dashboard look like the overview
dashboard.

It adds a cluster and dc view per operation, and use the latest chagnes
from the overview dashboard.

Signed-off-by: Amnon Heiman <amnon@scylladb.com>
@amnonh amnonh added this to the Monitoring 4.7 milestone Mar 20, 2024
@amnonh amnonh merged commit 52c6e74 into scylladb:master Mar 20, 2024
@amnonh amnonh deleted the run_alternator branch March 20, 2024 14:58
@amnonh amnonh mentioned this pull request May 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/alternator Alternator related Issues
Projects
None yet
Milestone
Monitoring 4.7
Development

Successfully merging this pull request may close these issues.
3 participants
@amnonh @mykaul @tzach