Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v1.11] Switch from in-tree mermaid client to out-of-tree manager client #1810

Merged
merged 3 commits into from
Mar 12, 2024
Merged

[v1.11] Switch from in-tree mermaid client to out-of-tree manager client #1810

merged 3 commits into from
Mar 12, 2024

Conversation

rzetelskik
Copy link
Member

Description of your changes: Backport of #1702.

Which issue is resolved by this Pull Request:
Prerequisite for #1675.

/priority important-longterm
/kind feature
/area dependency
/cc tnozicka

@scylla-operator-bot scylla-operator-bot bot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. kind/feature Categorizes issue or PR as related to a new feature. area/dependency Issues or PRs related to dependency changes size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 11, 2024
@rzetelskik rzetelskik mentioned this pull request Mar 11, 2024
Merged
@rzetelskik
Copy link
Member Author

flake #1478 (comment)
/retest

@rzetelskik
Copy link
Member Author

flake #1718 (comment)
/retest

tnozicka
tnozicka approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/assign @zimnx

@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rzetelskik, tnozicka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@scylla-operator-bot scylla-operator-bot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2024
@zimnx
Copy link
Collaborator

zimnx commented Mar 12, 2024

/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Mar 12, 2024
@scylla-operator-bot scylla-operator-bot bot merged commit 46ad382 into scylladb:v1.11 Mar 12, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnozicka tnozicka tnozicka approved these changes

Assignees

@zimnx zimnx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rzetelskik @zimnx @tnozicka