Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Scylla Manager to 3.2.7 #1880

Merged
merged 2 commits into from
May 15, 2024
Merged

Update Scylla Manager to 3.2.7 #1880

merged 2 commits into from
May 15, 2024

Conversation

rzetelskik
Copy link
Member

Description of your changes:
This PR updates Scylla Manager version in our manifests to 3.2.7. Most notably it fixes scylladb/scylla-manager#3769.

Which issue is resolved by this Pull Request:
Resolves #

/kind feature
/priority important-longterm

@scylla-operator-bot scylla-operator-bot bot added kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 4, 2024
@rzetelskik
Copy link
Member Author

Manager client is being updated in #1877.

tnozicka
tnozicka reviewed Apr 4, 2024
View reviewed changes
Copy link
Member

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing examples/scylladb/scylla.scyllacluster.yaml:6: agentVersion: 3.2.6

@rzetelskik
Copy link
Member Author

missing examples/scylladb/scylla.scyllacluster.yaml:6: agentVersion: 3.2.6

fixed, thanks

@rzetelskik rzetelskik requested a review from tnozicka April 4, 2024 10:06
@tnozicka
Copy link
Member

tnozicka commented Apr 4, 2024

/approve
/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2024
@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rzetelskik, tnozicka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@scylla-operator-bot scylla-operator-bot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2024
@rzetelskik
Copy link
Member Author

flake #1028 (comment)
/retest

@rzetelskik
Copy link
Member Author

/test images
/retest

@rzetelskik
Copy link
Member Author

manager flake #1694 (comment)
/test images
/retest

@rzetelskik
Copy link
Member Author

rzetelskik commented Apr 11, 2024 •
edited
Loading

@rzetelskik: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gke-parallel-clusterip 662eda2 link unknown /test e2e-gke-parallel-clusterip
Full PR test history. Your PR dashboard.

Manager flake #1694, second time on this PR.

Test got stuck on waiting for repair task deletion: https://prow.scylla-operator.scylladb.com/view/gs/scylla-operator-prow/pr-logs/pull/scylladb_scylla-operator/1880/pull-scylla-operator-master-e2e-gke-parallel-clusterip/1775908014201507840#1:test-build-log.txt%3A1120

I can see that the controller sent a request for task deletion:

2024-04-04T15:51:10.724078650Z I0404 15:51:10.590055       1 manager/sync.go:134] "Executing action" action="delete ta
sk \"cc49e122-0879-4e00-b6d0-68f67a0ec31f\""

Yet the task was never deleted from status. Looks like a controller bug, but the manager logs rolled, so I have no way of confirming that, and no way of verifying whether this update doesn't introduce a regression or make the flakiness worse.

I don't think this should be merged until the manager controller reaches a tolerable stability.
/hold

@scylla-operator-bot scylla-operator-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 11, 2024
@rzetelskik rzetelskik marked this pull request as draft April 15, 2024 09:19
@scylla-operator-bot scylla-operator-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 15, 2024
@tnozicka
Copy link
Member

but the manager logs rolled

why didn't we collect the "previous" logs? (we should)

@rzetelskik
Copy link
Member Author

why didn't we collect the "previous" logs? (we should)

previous logs are there, but current must have been trimmed.

$ cat artifacts/must-gather/namespaces/scylla-manager/pods/scylla-manager-controller-56bbb6b9b4-5q4mw/scylla-manager-controller.current | grep -e 'delete task \\"cc49e122-0879-4e00-b6d0-68f67a0ec31f\\"'
2024-04-04T15:51:10.724078650Z I0404 15:51:10.590055       1 manager/sync.go:134] "Executing action" action="delete task \"cc49e122-0879-4e00-b6d0-68f67a0ec31f\""
cat artifacts/must-gather/namespaces/scylla-manager/pods/scylla-manager-55596764c-5phf6/scylla-manager.current | sed -e 1b -e '$!d' | sed -e 's/\s.*$//'
2024-04-04T16:10:14.087323257Z
2024-04-04T16:17:58.071577325Z
cat artifacts/must-gather/namespaces/scylla-manager/pods/scylla-manager-55596764c-5phf6/scylla-manager.previous | sed -e 1b -e '$!d' | sed -e 's/\s.*$//'
2024-04-04T15:42:33.183142643Z
2024-04-04T15:44:33.866142243Z

@scylla-operator-bot scylla-operator-bot bot removed the lgtm Indicates that a PR is ready to be merged. label May 15, 2024
@rzetelskik rzetelskik marked this pull request as ready for review May 15, 2024 13:39
@scylla-operator-bot scylla-operator-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 15, 2024
@rzetelskik
Copy link
Member Author

/hold cancel

@scylla-operator-bot scylla-operator-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 15, 2024
@tnozicka
Copy link
Member

/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2024
@scylla-operator-bot scylla-operator-bot bot merged commit 9c73bd5 into scylladb:master May 15, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimnx zimnx Awaiting requested review from zimnx

@tnozicka tnozicka Awaiting requested review from tnozicka

Assignees

@tnozicka tnozicka

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Number of connections established by Scylla Manager outgrows system capabilities
2 participants
@rzetelskik @tnozicka