Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NodeConfig controller handlers to react on related object updates #2000

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Fix NodeConfig controller handlers to react on related object updates #2000

merged 1 commit into from
Jul 8, 2024

Conversation

tnozicka
Copy link
Member

@tnozicka tnozicka commented Jul 3, 2024 •
edited
Loading

Description of your changes:
This PR fixes the handlers so the reconciled objects that don't have ownerRefs on them requeue the NodeConfigs. Given they are shared, they need to requeue all of them but the number of NodeConfigs is usually low single digit number anyway.

Which issue is resolved by this Pull Request:
Resolves #2001

@tnozicka tnozicka added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jul 3, 2024
@scylla-operator-bot scylla-operator-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 3, 2024
@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

@tnozicka: GitHub didn't allow me to request PR reviews from the following users: tnozicka.

Note that only scylladb members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #

/cc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@scylla-operator-bot scylla-operator-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 3, 2024
@tnozicka tnozicka changed the title [WIP] Fix NodeConfig controller handlers [WIP] Fix NodeConfig controller handlers to react on related object updates Jul 3, 2024
@scylla-operator-bot scylla-operator-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 3, 2024
@scylla-operator-bot scylla-operator-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 3, 2024
@tnozicka tnozicka force-pushed the fix-nc-enqueue branch 2 times, most recently from ae76fff to 4e6ec94 Compare July 3, 2024 16:31
@tnozicka tnozicka changed the title [WIP] Fix NodeConfig controller handlers to react on related object updates Fix NodeConfig controller handlers to react on related object updates Jul 3, 2024
@scylla-operator-bot scylla-operator-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 3, 2024
@tnozicka tnozicka mentioned this pull request Jul 3, 2024
Merged
1 task
@tnozicka
Copy link
Member Author

tnozicka commented Jul 4, 2024

/cc @rzetelskik @zimnx

rzetelskik
rzetelskik reviewed Jul 4, 2024
View reviewed changes
Copy link
Member

@rzetelskik rzetelskik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment and one nit, rest lgtm

pkg/controllerhelpers/handlers.go Show resolved Hide resolved
pkg/controller/nodeconfig/controller.go Outdated Show resolved Hide resolved
zimnx
zimnx approved these changes Jul 4, 2024
View reviewed changes
Copy link
Collaborator

@zimnx zimnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
/assign rzetelskik

@rzetelskik rzetelskik self-requested a review July 4, 2024 15:59
rzetelskik
rzetelskik approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@rzetelskik rzetelskik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Jul 4, 2024
@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rzetelskik, tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tnozicka
Copy link
Member Author

tnozicka commented Jul 8, 2024

/retest
(likely slow clusterip again, need to find the link later)

@tnozicka
Copy link
Member Author

tnozicka commented Jul 8, 2024

/test images

@tnozicka
Copy link
Member Author

tnozicka commented Jul 8, 2024

/retest

@scylla-operator-bot scylla-operator-bot bot merged commit 24fd2fb into scylladb:master Jul 8, 2024
12 checks passed
@tnozicka tnozicka deleted the fix-nc-enqueue branch July 8, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rzetelskik rzetelskik rzetelskik approved these changes

@zimnx zimnx zimnx approved these changes

Assignees

@rzetelskik rzetelskik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ServiceAccount and other objects managed by NodeConfig are not reconciled on update
3 participants
@tnozicka @zimnx @rzetelskik