Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add resourceapply helpers for PersistentVolumeClaims #2004

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Add resourceapply helpers for PersistentVolumeClaims #2004

merged 1 commit into from
Jul 4, 2024

Conversation

rzetelskik
Copy link
Member

Description of your changes: This PR adds resourceapply helpers for PersistentVolumeClaims. Required for https://github.com/scylladb/scylla-operator-ci-tools/pull/12.

Which issue is resolved by this Pull Request:
Resolves #

/kind feature
/priority important-soon

@scylla-operator-bot scylla-operator-bot bot added kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 4, 2024
@rzetelskik
Copy link
Member Author

@rzetelskik: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gke-parallel 84205c5 link true /test e2e-gke-parallel
Full PR test history. Your PR dashboard.

New flake #2005.
In my opinion it can't possibly be caused by this change though.

/retest

zimnx
zimnx approved these changes Jul 4, 2024
View reviewed changes
Copy link
Collaborator

@zimnx zimnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@scylla-operator-bot scylla-operator-bot bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 4, 2024
@tnozicka
Copy link
Member

tnozicka commented Jul 4, 2024

/approve

@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rzetelskik, tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@scylla-operator-bot scylla-operator-bot bot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 4, 2024
@rzetelskik rzetelskik requested a review from zimnx July 4, 2024 15:05
@zimnx
Copy link
Collaborator

zimnx commented Jul 4, 2024

/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Jul 4, 2024
@scylla-operator-bot scylla-operator-bot bot merged commit c90b086 into scylladb:master Jul 4, 2024
12 checks passed
@rzetelskik rzetelskik deleted the pvc-resourceapply branch July 4, 2024 16:00
@tnozicka tnozicka added kind/machinery Categorizes issue or PR as related to Makefile, scripts or similar changes. and removed kind/feature Categorizes issue or PR as related to a new feature. labels Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnozicka tnozicka Awaiting requested review from tnozicka

@zimnx zimnx Awaiting requested review from zimnx

Assignees

@zimnx zimnx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/machinery Categorizes issue or PR as related to Makefile, scripts or similar changes. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rzetelskik @tnozicka @zimnx