-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove host networking mentions from documentation and examples #2087
Conversation
/approve We should also remove it from examples (eks and gke are enabling it), would you mind removing these too? |
We should not recommend nor support it. Signed-off-by: Yaniv Kaul <yaniv.kaul@scylladb.com> Refs: scylladb#1378
We should not recommend nor support it. Removing it in the examples is the next step after docs. Signed-off-by: Yaniv Kaul <yaniv.kaul@scylladb.com> Refs: scylladb#1378
Added a commit to remove it from the examples. We still have it around in other places, I think these are minor:
|
The rest are fine, they will be gone once we eventually stop supporting it. |
I went through a grep as well and it looks like this wasn't actually in too many places modulo the CRD definitions or generated API reference. /approve Thanks @mykaul |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mykaul, tnozicka, zimnx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I assume this should be backported to 1.13 release branch. How do I do it? Manually? |
yes, manual backport + PR to |
We should not recommend nor support it.
Refs: #1378