conn: copy a batch type in prepare_batch #1038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
3 tasks
Lorak-mmk
reviewed
Jul 10, 2024
Previously, there was a bug in prepare_batch function. We wouldn't inherit a BatchType from the `initial_batch` - in result, we would always send LOGGED batches (since LOGGED is a default batch type). This would result in server errors when including a counter statements in a LOGGED batch. I added a test case which checks that it works correctly now, and the driver sends a COUNTER batch when user asks to.
muzarski
force-pushed
the
counter_batch_fix
branch
from
f4962c6 to
5a0d6e7
Compare
|
v2: Added a |
wprzytula
approved these changes
Jul 10, 2024
Lorak-mmk
approved these changes
Jul 10, 2024
wprzytula
added a commit
to wprzytula/scylla-rust-driver
that referenced
this pull request
Jul 11, 2024
conn: copy a batch type in prepare_batch (cherry picked from commit ea0a4d0)
Merged
wprzytula
added a commit
to wprzytula/scylla-rust-driver
that referenced
this pull request
Jul 11, 2024
conn: copy a batch type in prepare_batch (cherry picked from commit ea0a4d0)
wprzytula
added a commit
to wprzytula/scylla-rust-driver
that referenced
this pull request
Jul 11, 2024
conn: copy a batch type in prepare_batch (cherry picked from commit ea0a4d0)
wprzytula
added a commit
to wprzytula/scylla-rust-driver
that referenced
this pull request
Jul 11, 2024
conn: copy a batch type in prepare_batch (cherry picked from commit ea0a4d0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #1035
Previously, there was a bug in prepare_batch function. We wouldn't inherit a BatchType from the
initial_batch- in result, we would always send LOGGED batches (since LOGGED is a default batch type).This would result in server errors when including a counter statements in a LOGGED batch. I added a test case which checks that it works correctly now, and the driver sends a COUNTER batch when user asks to.
Pre-review checklist
[ ] I have provided docstrings for the public items that I want to introduce.[ ] I have adjusted the documentation in./docs/source/.Fixes:annotations to PR description.