node: tiny optimizations and code refactors #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can consume the `to_resolve` vector and move the datacenter string, instead of cloning.
In previous version, we would needlessly allocate vectors while having iterators over SocketAddrs.
Notice that using `find_or_last` is equivalent to previous version.
This is just a negation of `is_empty()` method.
For reference:
```
fn is_empty(&self) -> bool {
self.conns.iter().all(|conns| conns.is_empty())
}
```
|
|
Lorak-mmk
approved these changes
Oct 25, 2024
wprzytula
approved these changes
Oct 26, 2024
Comment on lines
+283
to
+290
| addrs | ||
| .find_or_last(|addr| matches!(addr, SocketAddr::V4(_))) | ||
| .ok_or_else(|| { | ||
| io::Error::new( | ||
| io::ErrorKind::Other, | ||
| format!("Empty address list returned by DNS for {}", hostname), | ||
| ) | ||
| }) |
There was a problem hiding this comment.
Any ideas BTW why we're biased for IPv4 addresses???
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reading, and trying to understand the hostname resolution and pool refiller logic, I found some places where things could be slightly adjusted. These changes are mostly tiny optimizations and things that aid code readability.
Pre-review checklist
./docs/source/.Fixes:annotations to PR description.