Fix RoutingInfo consistency #743
Commits on Jul 27, 2023
-
scylla_cql: Impl TryFrom<u8> for BatchType
This will be used in proxy, to inspect request frames from the driver.
-
value: fix statements-value count mismatch message
The generated error contained wrong value list count: it failed to include the number of value lists that were already paired with statements. As a bonus, a cleaner `count()` implementation was added to `BatchValuesIterator` trait, instead of using a dirty workaround.
-
scylla_cql: get rid of iterator in Batch
The iterator is not an accurate choice: the Batch struct does not contain any iteration state, so a plain slice would be a better choice.
-
scylla_cql: Cow gives requests flexible ownership
Before, only borrowed requests were allowed (for instance, Query contained the borrowed query contents as &str). For convenient deserialization and for test purposes, owned requests are preferred, so the definitions are made contain `Cow`s.
-
scylla_cql: derive test Debug for some requests
This will be used in some tests.
-
scylla_cql: derive test Eq for some types
This is required for tests.
-
scylla_cql: add deser capabilities for requests
Introduces DeserializableRequest trait whose main goal is testing purposes.
-
scylla_cql: add tests for request deserialization
One simply asserts that serialization composed with deserialization is identity. Another makes sure that unknown flags lead to frame rejection (as deserializing frame containing unknown flags will likely lead to misinterpretation of some unknown protocol extensions).
-
scylla_cql: rename Request to SerializableRequest
The mentioned trait essentially serves the purpose of serialization, so the change is justified. The name `Request` will be used for an umbrella enum containing various types of requests.
-
scylla_cql: introduce Request umbrella enum
This enum provided unified interface over CQL requests, useful for testing. Now, it supports only Query, Execute and Batch (it panics if attempted to deserialize a different opcode) and provided getters for Consistency and SerialConsistency. In the future, it can be extended for further test checks.
-
integration: add tests for [serial] consistency
One test checks for each [serial] possible consistency that the request frame indeed contains the specified [serial] consistency. Another test checks that RoutingInfo's consistencies match the specified ones. As the latter test confirmed the bug in Session regarding RoutingInfo, it is temporarily marked as ignored. The mark will be removed in the next commit, after the bug is fixed.
-
session: fix: set correct consistency in RoutingInfo
The test added in the previous commit proves that the routing info has wrong Consistency and SerialConsistency set. Therefore, Session::query_paged(), execute_paged() and batch() are all fixed to respect correct consistencies. The test's "ignore" mark is henceforth removed.
-
session: pass exec profile to Session::run_query()
As access to the execution profile is anyway needed in the callers of `Session::run_query()` (in order to put correct Consistency and SerialConsistency into RoutingInfo), the acquired Arc<ExecutionProfileInner> is passed to `Session::run_query()` as another argument. This prevents duplication of Arc cloning.
-
session: ExecuteQueryContext::consistency -> ...set_on_statement
There are three levels of consistency that are taken into account by the Session: default exec profile's, per-statement exec profile's and per-statement one. To avoid confusion, we should use naming that clearly distinguishes them. Therefore, ExecuteQueryContext's field is renamed from the vague `consistency` to `consistency_set_on_statement` (the one directly set), as it is exactly its semantics.
-
iterator: fix: set correct consistency in RoutingInfo
Apparently, routing info had wrong Consistency and SerialConsistency set in iterator, too.
