-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
treewide: silence mock structs unused warning #996
treewide: silence mock structs unused warning #996
Conversation
With a new version of Rust toolchain, our never constructed structs used for testing macros began to trigger rustc warnings. They are silenced explicitly using #[allow(unused)].
If considerably many users are already using the new toolchain, we may want to consider releasing a patch version to silence those warnings. |
|
I see only changes in tests, it should not affect users of the driver so I don't see the point at all. When are the warnings fixed by this PR triggered? I didn't see any failed CI runs because of this. |
Agreed.
They pop up when I run
Done. |
Then why is CI not failing on other PRs? |
Ah, it's probably not failing because we use Rust provided on CI runner images instead of setting up our own and I guess they were not updated yet. |
Eh, I forgot to check the commit message and you use |
…ever-constructed treewide: silence mock structs unused warning (cherry picked from commit c25c54d)
With a new version of Rust toolchain (stable 1.78.0), our never constructed structs used for testing macros began to trigger rustc warnings. Now, they are silenced explicitly using
#[allow(unused)]
.Pre-review checklist
[ ] I added relevant tests for new features and bug fixes.[ ] I have provided docstrings for the public items that I want to introduce.[ ] I have adjusted the documentation in./docs/source/
.[ ] I added appropriateFixes:
annotations to PR description.