build: support c-ares >= 1.34.1 #2486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
|
Nice work on upstreaming the fix so quickly. |
in c-ares 1.34.0, it addressed a regression with custom socket callbacks due to DNS cookie support. because 1.34.0's release tarball failed to include some header file. so let's claim the support to c-ares < 1.33 or >= 1.34.1. Refs scylladb#2472 Signed-off-by: Kefu Chai <kefu.chai@scylladb.com>
tchaikov
force-pushed
the
c-ares-1.34.1
branch
from
719f910
to
ad17b37
Compare
|
BTW, the bz for updating f41's c-ares packaging is https://bugzilla.redhat.com/show_bug.cgi?id=2307596 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in c-ares 1.34.0, it addressed a regression with custom socket callbacks due to DNS cookie support. because 1.34.0's release tarball failed to include some header file. so let's claim the support to c-ares < 1.33 or >= 1.34.1.
Refs #2472
Signed-off-by: Kefu Chai kefu.chai@scylladb.com