core: reactor_config: add reserve_io_control_blocks #2533
Merged
+21
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 11, 2024
|
Who should review this? @denesb |
@avikivity would be the best candidate, since he was part of the discussion from which this patch was born (scylladb/scylladb#19185). |
avikivity
reviewed
Nov 13, 2024
|
New in v2: ensure |
This new option allows reserving the configured amount of IOCBs, so they are available to a side application running in parallell to the seastar application. The use case is ScyllaDB and its tool applications, both ScyllaDB and its tool applications need IOCBs to run, so ScyllaDB has to be able to tell seastar to reserve some IOCBs for the tools as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new option allows reserving the configured amount of IOCBs, so they are available to a side application running in parallell to the seastar application.
The use case is ScyllaDB and its tool applications, both ScyllaDB and its tool applications need IOCBs to run, so ScyllaDB has to be able to tell seastar to reserve some IOCBs for the tools as well.