Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activation constructor/destructor cleanup #32

Merged
merged 2 commits into from
Apr 28, 2023

Conversation

mikeoliphant
Copy link
Contributor

This PR just cleans up the Activation class constructor/destructors. It wasn't currently a problem (although it could have been in the future), but it gits rid of a bunch of annoying compiler warnings.

Copy link
Owner

@sdatkinson sdatkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏻

@sdatkinson sdatkinson merged commit 1e42173 into sdatkinson:main Apr 28, 2023
@mikeoliphant mikeoliphant deleted the activation_destructor branch May 8, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants