[BREAKING] Change module imports to private scope

[zghannam]

Refactored the imports for first and third-party imports for issue #510, but not in-package imports yet. Can absolutely change anything if needed. Didn't break anything as far as I can tell (still passing all provided test cases) and was formatted with Black.

[sdatkinson]

Cool! Yes, this is in the right direction so I'll approve.

My eyes caught a few stragglers like numpy as np.

Since there's so much line diff already, I don't mind merging this PR and taking another PR for more so that it's easier to process piece by piece for me.

[sdatkinson]

Ah, actually one other thing we'll want to do is bump the minor version to 0.12.0 since this is breaking. That needs to happen in nam/_version.py and in the docs conf.py.

[zghannam]

Yeah sorry about the larger PR. I left the "import numpy as np" and other similar imports since that was actually there already and I didn't know if I should be changing any existing names.

So just to make sure whats left: fix some of the existing import names like "import numpy as np", change the version in the mentioned files, and finish up adding names for imports within the package like "from .lightning_module import LightningModule as _LightningModule"?

[sdatkinson]

@zghannam yep! The version bit would be enough for me to merge the PR but all of that and I think it's sufficient to resolve the Issue 👍🏻

[sdatkinson]

Thanks for all this work; it's quite a diff!

Just a couple things with "[C]" that I'd like to see addressed before I can approve. Nits, feel free to address optionally; I'd be happy to merge either way.

[zghannam]

Sorry about some of those, don't know how I missed them. Merged with the main branch and those changes should be resolved now

[sdatkinson]

LGTM 👍🏻